[Webkit-unassigned] [Bug 61834] Web Inspector: CRASH if Expanding Event Listener on document

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jun 4 22:13:04 PDT 2011


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
  Attachment #96009|review?, commit-queue?      |review-
               Flag|                            |

--- Comment #11 from Pavel Feldman <pfeldman at chromium.org>  2011-06-04 22:13:04 PST ---
(From update of attachment 96009)
View in context: https://bugs.webkit.org/attachment.cgi?id=96009&action=review

The reason I prefer sniffer to the runAfterPendingDispatches is that it tests exactly what I expect. runAfterPendingDispatches is called not after a particular action I am testing, but after its potential implications. Also, it just makes us run more code while in the test (all subsequent updates for styles and such) and hence reduce the test robustness.

> LayoutTests/inspector/elements/event-listener-sidebar.html:27
> +        function testSetupEventListeners(next)

You no longer need neither testSetupEventListeners nor the testSuite sequence (just selectNode followed with expandAndDump)

> LayoutTests/inspector/elements/event-listener-sidebar.html:51
> +<body onload="runTest()">

you want onloadHandler call here.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list