[Webkit-unassigned] [Bug 61915] [EFL][WK2] Add efl port's ewk_view files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61915


Leandro Pereira <leandro at profusion.mobi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95847|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #11 from Leandro Pereira <leandro at profusion.mobi>  2011-06-03 10:23:31 PST ---
(From update of attachment 95847)
View in context: https://bugs.webkit.org/attachment.cgi?id=95847&action=review

I know nothing about WebKit2. I'm reviewing only style and other possibly minor issues.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:286
> +    if (!sd->priv) {
> +        EINA_LOG_CRIT("could not allocate _Ewk_View_Private_Data");
> +        free(sd);
> +        return;

Dangling reference. evas_object_smart_data_set(o, 0);

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:320
> +    EWK_VIEW_SD_GET(o, sd);

EWK_VIEW_SD_GET_OR_RETURN(...)

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:332
> +    EWK_VIEW_SD_GET(o, sd);

Ditto. Please review all EWK_VIEW_SD_GET() usage on the following functions.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.