[Webkit-unassigned] [Bug 61915] [EFL][WK2] Add efl port's ewk_view files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61915





--- Comment #10 from EunMi Lee <eunmi15.lee at samsung.com>  2011-06-02 21:55:12 PST ---
(In reply to comment #7)
> View in context: https://bugs.webkit.org/attachment.cgi?id=95846&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_view.h:41
> > +    //  - if overridden, have to call parent method if desired
> 
> If possible, I like to use /* */ instead of // for c header.
> 
Done. I change // to /**/

> > Source/WebKit2/UIProcess/API/efl/ewk_view.h:102
> > +    Evas_Object *backing_store; /**< reference to backing store */
> 
> it's missed.
Done.

> 
> > Source/WebKit2/UIProcess/API/efl/ewk_view.h:115
> > +EAPI WKPageRef ewk_view_page_get(Evas_Object*);
> 
> Isn't it better to keep a parameter name like WebKit/EFL?
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_view.h:120
> > +#endif // ewk_view_h
> 
> Ditto.
Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.