[Webkit-unassigned] [Bug 61963] bindings/v8/DOMData.h/.cpp has numerous errors in processing DOMDataStores for different threads

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61963





--- Comment #7 from Dmitry Lomov <dslomov at google.com>  2011-06-02 17:03:19 PST ---
(From update of attachment 95815)
View in context: https://bugs.webkit.org/attachment.cgi?id=95815&action=review

>> Source/WebCore/bindings/v8/DOMData.h:88
>> +            if (store->domData()->owningThread() != WTF::currentThread())
> 
> Actually I take back my r+. Why is this change correct?
> 
> How does this function get called on the wrong thread?  And if it get called on the wrong thread, won't there be problems since removeIfPresent wasn't called?

This function only gets called on a wrong thread in (future) patch with Isolates, and currently DOM stores are affined to the threads.
But it is not a good function indeed - it accesses the stores list without a mutex anyway, so doesn't really work in multithreaded situation; and the above has performance problems.

I'll revert this bit, and restructure this for isolates in later fix.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.