[Webkit-unassigned] [Bug 61963] bindings/v8/DOMData.h/.cpp has numerous errors in processing DOMDataStores for different threads

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 2 16:23:04 PDT 2011


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
  Attachment #95815|review+                     |review-
               Flag|                            |

--- Comment #6 from David Levin <levin at chromium.org>  2011-06-02 16:23:05 PST ---
(From update of attachment 95815)
View in context: https://bugs.webkit.org/attachment.cgi?id=95815&action=review

> Source/WebCore/bindings/v8/DOMData.h:88
> +            if (store->domData()->owningThread() != WTF::currentThread())

Actually I take back my r+. Why is this change correct?

How does this function get called on the wrong thread?  And if it get called on the wrong thread, won't there be problems since removeIfPresent wasn't called?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list