[Webkit-unassigned] [Bug 65372] New: check-webkit-style complains about missing config.h in files from Tools/

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65372

           Summary: check-webkit-style complains about missing config.h in
                    files from Tools/
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ademar.reis at openbossa.org


We usually don't use WebCore's config.h in source files from Tools/ (it's not even in the include path most of the time) but check-webkit-style complains.

See for example:
https://bugs.webkit.org/show_bug.cgi?id=65328#c11

"""
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/QtTestBrowser/Qt..." exit_code: 1

Tools/QtTestBrowser/cookiejar.cpp:28:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 7 files

"""

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.