[Webkit-unassigned] [Bug 64851] Optimize AnimationController::updateAnimations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64851





--- Comment #11 from Dean Jackson <dino at apple.com>  2011-07-29 01:56:28 PST ---
(From update of attachment 101705)
View in context: https://bugs.webkit.org/attachment.cgi?id=101705&action=review

You'll have to wait until an official reviewer gives the r+. The two most familiar with the animation code are Simon and Chris, who are on vacation until Monday. I will try to find someone sooner.

Otherwise, this looks good. Thanks!

> Source/WebCore/ChangeLog:3
> +        Fix for bug 64851 - No need to call updateAnimationTimer() in the process of "Attach" when loading page with only CSS3 transition property but no animation property.

I think the title here should be "Avoid calling animation timer updates while the page is loading"

> Source/WebCore/ChangeLog:8
> +        No new tests. 

... and then here you should describe the change. For example:

There is no need to update the animation timer for a RenderObject that has not yet been inserted into the render tree, or that doesn't have animations. Our tests show that this improves page loading by up to 3x on pages with a large number of transitionable objects.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.