[Webkit-unassigned] [Bug 64851] Optimize AnimationController::updateAnimations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64851





--- Comment #10 from zeng huiqing <huiqing.zeng at intel.com>  2011-07-25 07:58:08 PST ---
For page loading test, find that if load a page w/ CSS3 transition property, especially when page contains many RenderObjects w/ transition property, FF4 performs ~5.5X faster than Chromium&Safari.

Through analysis, find that the root cause is that w/ transition property, when a dom element is attached, it will call RenderObject::setAnimatableStyle, then AnimationController::updateAnimations, and it will call AnimationController::updateAnimationTimer, which is the hotspot.

And, in my opinion, we may do not need to call updateAnimationTimer() in the process of "Attach" when loading page w/ only CSS3 transition property actually.

Had submit a patch,use 'renderer->parent()' in function updateAnimations() to avoid calling updateAnimationTimer() in the process of "attached" when loading page with only CSS3 transition property but no animation property.
The patch will reduce page(with transition property) loading time by 70%, improve the performance by 3.3X.

Could someone possibly help review the patch when have a moment? Thanks very much:)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.