[Webkit-unassigned] [Bug 65200] CSS Regions build bot should archive and upload output files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65200





--- Comment #6 from Chiculita Alexandru <achicu at adobe.com>  2011-07-28 11:54:29 PST ---
(From update of attachment 102233)
View in context: https://bugs.webkit.org/attachment.cgi?id=102233&action=review

Thanks for the review.

>> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:247
>> +                      "upload": "true", "slavenames": ["adobe-mac-slave1"]
> 
> You can use a literal true value here. No need for the string. That will make the master.cfg logic simpler.

Ok.

>> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:-131
>> -
> 
> You should leave this extra line in place to match standard Python style.

Ok.

>> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:133
>> +    masterdest = WithProperties("archives/%(fullPlatform)s-%(architecture)s-%(configuration)s%(extraFeatures)s/%(got_revision)s.zip", extraFeatures=lambda build:UploadBuiltProduct.determineExtraFeatures(build))
> 
> I'm surprised the lambda is needed.

determineExtraFeatures will only be defined after this initialization. I'm new to python, so I might be wrong. The options that I found to be working are:
a. put the method at the module level 
b. use the lambda
c. move the method before masterdest, but I think it looks better to have the properties grouped at the top

>> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:741
>> +            "upload": builder.pop("upload", None) == "true"
> 
> False would probably be a better default, especially once you start using a real True value instead of a string.

Ok.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.