[Webkit-unassigned] [Bug 65200] CSS Regions build bot should archive and upload output files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65200


Adam Roben (:aroben) <aroben at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102233|review?                     |review-
               Flag|                            |




--- Comment #5 from Adam Roben (:aroben) <aroben at apple.com>  2011-07-28 07:46:41 PST ---
(From update of attachment 102233)
View in context: https://bugs.webkit.org/attachment.cgi?id=102233&action=review

This is looking really close!

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:247
> +                      "upload": "true", "slavenames": ["adobe-mac-slave1"]

You can use a literal true value here. No need for the string. That will make the master.cfg logic simpler.

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:-131
> -

You should leave this extra line in place to match standard Python style.

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:133
> +    masterdest = WithProperties("archives/%(fullPlatform)s-%(architecture)s-%(configuration)s%(extraFeatures)s/%(got_revision)s.zip", extraFeatures=lambda build:UploadBuiltProduct.determineExtraFeatures(build))

I'm surprised the lambda is needed.

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:741
> +            "upload": builder.pop("upload", None) == "true"

False would probably be a better default, especially once you start using a real True value instead of a string.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.