[Webkit-unassigned] [Bug 64790] [GTK][WK2] Handle doneWithKeyEvent in GTK port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64790


Ravi Phaneendra Kasibhatla <ravi.kasibhatla at motorola.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101997|0                           |1
        is obsolete|                            |
 Attachment #102258|                            |review?
               Flag|                            |




--- Comment #27 from Ravi Phaneendra Kasibhatla <ravi.kasibhatla at motorola.com>  2011-07-28 07:49:09 PST ---
Created an attachment (id=102258)
 --> (https://bugs.webkit.org/attachment.cgi?id=102258&action=review)
Implementation for doneWithKeyEvent for WK2 GTK port - revision 5

Addressed the concerns & comments of carlos & martin.
As per explanation given by Carlos, since gtk_main_do_event is sync & gets invoked only for event which is being passed gtk_main_do_event, reverting to boolean flag. 
As per understanding with Martin & Carlos now keeping the WebKitWebViewPrivate in .cpp only and exposing a new API to set the flag from PageClientImpl.
As per discussion with Carlos & Martin, NativeWebKeyboardEvent::nativeEvent now returns a non-const GdkEvent. Removing the casting & event copy from PageClientImpl.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.