[Webkit-unassigned] [Bug 64790] [GTK][WK2] Handle doneWithKeyEvent in GTK port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64790





--- Comment #26 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-07-26 08:24:12 PST ---
(In reply to comment #22)
> I still though have one concern in calling gtk_main_do_event(). Consider a usecase, where key_press gets handled by web process but not key_release. Since we are calling gtk_main_do_event(), we again get key_press & key_release callbacks to WebKitWebViewBase widget. With our flag for handled status, we will pass key_release to parent widget, but key_press gets propagated again to web process. Wouldn't that be an issue?

No, with gtk_main_do_event() we only process the event that was not handled by the we process, if key press is handled by not key release, doneWithKeyEvent will be called with handled=true only for the key press event, so we will call gtk_main_do_event() only for the key release. I don't think we need the enum, since doneWithKeyEvent will be called for every key press/release event, the boolean is enough, events are handled synchronously by gtk+.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.