[Webkit-unassigned] [Bug 65171] CSS Regions build bot should build with "--css-regions" and "--css-exclusion" flags

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65171





--- Comment #3 from Chiculita Alexandru <achicu at adobe.com>  2011-07-26 10:37:11 PST ---
(In reply to comment #2)

> FWIW, on the flexbox bot, I just modified files in the checkout to have it compile with the necessary flags and to enable the layout tests (removed the SKIP line from test_expectations.txt).  It's a bit fragile since I have to manually fix merge conflict, but that hasn't happened yet.

I think we might better add support to overwrite/preprocess test_expectation. I will add a bug for that.

> Nit: I would remove this type check, I'm not sure it provides much safety other than hiding config.json errors.  Also, it seems like any iterable would work.

Thanks. The value should come from the JSON Decoder, which will only generate dict or list iterable objects. I can move that check at the parse time and throw an exception.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.