[Webkit-unassigned] [Bug 65171] CSS Regions build bot should build with "--css-regions" and "--css-exclusion" flags

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65171





--- Comment #2 from Tony Chang <tony at chromium.org>  2011-07-26 09:55:28 PST ---
(From update of attachment 101984)
View in context: https://bugs.webkit.org/attachment.cgi?id=101984&action=review

This seems fine to me, but aroben might have some additional feedback.

FWIW, on the flexbox bot, I just modified files in the checkout to have it compile with the necessary flags and to enable the layout tests (removed the SKIP line from test_expectations.txt).  It's a bit fragile since I have to manually fix merge conflict, but that hasn't happened yet.

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:108
> +        if isinstance(features, list):

Nit: I would remove this type check, I'm not sure it provides much safety other than hiding config.json errors.  Also, it seems like any iterable would work.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.