[Webkit-unassigned] [Bug 64580] Add support for download='filename' in anchors

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jul 23 17:34:27 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=64580





--- Comment #60 from sadrul at chromium.org  2011-07-23 17:34:27 PST ---
> > Source/WebCore/html/HTMLAnchorElement.cpp:515
> > +        if (!hasRel(RelationNoReferrer)) {
> > +            String referrer = frame->loader()->outgoingReferrer();
> > +            if (!referrer.isEmpty() && !SecurityOrigin::shouldHideReferrer(kurl, referrer))
> > +                request.setHTTPReferrer(referrer);
> > +            frame->loader()->addExtraFieldsToMainResourceRequest(request);
> > +        }
> 
> It's pretty horrible to duplicate this code.

I couldn't find a clean way of avoiding the duplication here. The code is reasonably small and simple that perhaps this duplication is tolerable? But I am all-ears for suggestions to make this better :-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list