[Webkit-unassigned] [Bug 64731] Add MediaSource API to HTMLMediaElement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64731





--- Comment #13 from Aaron Colwell <acolwell at chromium.org>  2011-07-20 08:57:11 PST ---
(In reply to comment #12)
> (From update of attachment 101371 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=101371&action=review
> 
> > Source/WebCore/html/HTMLMediaElement.cpp:198
> > +    m_mediaSourceURL.setProtocol(mediaSourceURLProtocol);
> > +    m_mediaSourceURL.setPath(createCanonicalUUIDString());
> 
> Why isn't *all* of the code for this experiment wrapped with #if ENABLE(MEDIA_SOURCE)?

I'll fix this. I didn't know how much #ifdefing would be tolerated. I just #ifdefed out the stuff that was exposed in the DOM. I'm assuming that you mean I should put #ifdefs every single source file I've modified.

> 
> 
> > Source/WebCore/html/HTMLMediaElement.cpp:1675
> > +    if (m_sourceState == SOURCE_CLOSED) {
> > +        scheduleEvent(eventNames().closeEvent);
> > +        return;
> > +    }
> > +
> > +    if (oldState == SOURCE_CLOSED && m_sourceState == SOURCE_OPEN) {
> > +        scheduleEvent(eventNames().openEvent);
> > +        return;
> 
> Is it safe to use un-prefixed event names for an experimental feature?
Probably not. Should I change this to webkitSourceOpen or something like that.

I'm open to suggestions. This is my first time trying to add an experimental feature so I'd appreciate any tips you may have.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.