[Webkit-unassigned] [Bug 64731] Add MediaSource API to HTMLMediaElement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64731





--- Comment #12 from Eric Carlson <eric.carlson at apple.com>  2011-07-20 08:39:51 PST ---
(From update of attachment 101371)
View in context: https://bugs.webkit.org/attachment.cgi?id=101371&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:198
> +    m_mediaSourceURL.setProtocol(mediaSourceURLProtocol);
> +    m_mediaSourceURL.setPath(createCanonicalUUIDString());

Why isn't *all* of the code for this experiment wrapped with #if ENABLE(MEDIA_SOURCE)?


> Source/WebCore/html/HTMLMediaElement.cpp:1675
> +    if (m_sourceState == SOURCE_CLOSED) {
> +        scheduleEvent(eventNames().closeEvent);
> +        return;
> +    }
> +
> +    if (oldState == SOURCE_CLOSED && m_sourceState == SOURCE_OPEN) {
> +        scheduleEvent(eventNames().openEvent);
> +        return;

Is it safe to use un-prefixed event names for an experimental feature?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.