[Webkit-unassigned] [Bug 64790] [GTK][WK2] Handle doneWithKeyEvent in GTK port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64790





--- Comment #7 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-07-20 00:10:51 PST ---
(From update of attachment 101429)
View in context: https://bugs.webkit.org/attachment.cgi?id=101429&action=review

With the patch the focus never moves to the toolbar, I'm not sure what the right behaviour is, but with GtkLauncher the toolbar is focused at some point after pressing tab several times.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:329
> +void webkitWebViewBaseDidNotHandleKeyEvent(WebKitWebViewBase* webViewBase, const GdkEventKey* keyEvent)
> +{
> +    GTK_WIDGET_CLASS(webkit_web_view_base_parent_class)->key_press_event(GTK_WIDGET(webViewBase), const_cast<GdkEventKey*>(keyEvent));
> +}
> +

I'm not sure about this, maybe it would be better to use gtk_main_do_event() so that the event is properly handled again by GTK and added to the stack. Event callbacks expect functions gtk_get_current_event* to work. We would need to add a boolean flag to tell the view we are forwarding an event not handled by the web process and simply call gtk_main_do_event(). In key_press and key_release, we check that flag and if set, we simply unset it and call key_press_event on parent widget.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.