[Webkit-unassigned] [Bug 64790] [GTK][WK2] Handle doneWithKeyEvent in GTK port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64790





--- Comment #6 from Ravi Phaneendra Kasibhatla <ravi.kasibhatla at motorola.com>  2011-07-19 23:19:38 PST ---
(In reply to comment #4)
> (From update of attachment 101337 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=101337&action=review
> 
> Looks good, but I have a few nits.
> 
> > Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:216
> > +                                             reinterpret_cast<const GdkEventKey*>(event.nativeEvent()));
> 
> The indentation is off here and you should just do: &event.nativeEvent()->key or similar.
Done.
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:330
> > +                GTK_WIDGET(webViewBase),
> > +                const_cast<GdkEventKey*>(keyEvent));
> 
> No need to break this line. It isn't right to simply cast away the constness here. The NativeWebKeyboardEvent is not expecting the GdkEventKey to change. Probably it's better to make a copy of the event and send that.
When invoking GTK_WIDGET_CLASS(webkit_web_view_base_parent_class)->key_press_event, we need to do const_cast<GdkEventKey*> since the API expects a non-const GdkEventKey* and we have a const GdkEventKey*.
Addressed the other points in the comment.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.