[Webkit-unassigned] [Bug 64786] The value of a number input form continues to increase/decrease even if we disable the input form.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64786


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101426|review?                     |review-
               Flag|                            |




--- Comment #14 from Kent Tamura <tkent at chromium.org>  2011-07-19 22:48:13 PST ---
(From update of attachment 101426)
View in context: https://bugs.webkit.org/attachment.cgi?id=101426&action=review

> LayoutTests/fast/forms/spin-button-gets-disabled-or-readonly.html:60
> +        setTimeout(function() {
> +            shouldBeEqualToString('input.value', "1234566");
> +            nextDelayTest();
> +        }, 500);

We can know the first increment/decrement by 'input' event. Can we avoid setTime() by 'input' event handler?

> Source/WebCore/html/TextFieldInputType.cpp:244
> +    if (m_innerSpinButton)
> +        static_cast<SpinButtonElement*>(innerSpinButtonElement())->releaseCapture();

We can avoid static_cast by changing the type of m_innerSpinButton from RefPtr<HTMLElement> to RefPtr<SpinButtonElement>.

> Source/WebCore/html/TextFieldInputType.cpp:250
> +        static_cast<SpinButtonElement*>(innerSpinButtonElement())->releaseCapture();

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.