[Webkit-unassigned] [Bug 57154] [Qt] Make OpenGL symbol resolver transparent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57154





--- Comment #31 from Noam Rosenthal <noam.rosenthal at nokia.com>  2011-07-18 18:33:13 PST ---
> So this patch is still kind of big, but very straightforward. It just deletes a bunch of typedefs, proc member declarations and assignments that were the old resolver. Then it changes each call to the old symbol resolver to use the new one (e.g. m_internal->bindFramebuffer becomes glBindFramebuffer etc.) - so just a bunch of single line diffs where it's very clear what is changing.
> 
> I think this will be much easier to review.

I'm having a hard time when the patch contains stuff in the Cairo directory, even though it looks rather trivial.
The Qt stuff looks OK, if you could get Martin Robinson or someone familiar with Cairo OpenGLShims to review changes to those files, perhaps in an additional bug, I'd be happy to review the Qt specific stuff.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.