[Webkit-unassigned] [Bug 57154] [Qt] Make OpenGL symbol resolver transparent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57154


Andrew Wason <rectalogic at rectalogic.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100678|0                           |1
        is obsolete|                            |
 Attachment #100678|review?                     |
               Flag|                            |
 Attachment #101209|                            |review?
               Flag|                            |




--- Comment #30 from Andrew Wason <rectalogic at rectalogic.com>  2011-07-18 14:53:37 PST ---
Created an attachment (id=101209)
 --> (https://bugs.webkit.org/attachment.cgi?id=101209&action=review)
use OpenGLShims resolver implementation

(In reply to comment #29)
> It's a pretty big patch; Hard to review...
> Could you break it down a bit

The patch had some additional changes not directly related to adopting the shims resolver - it was also removing things from GraphicsContext3DInternal and using the corresponding members in GraphicsContext3D instead - holdovers from jarkkos original patch.

I'm going to move those changes to separate patches for bug 57261 where they belong, and this patch now only addresses changing the symbol resolver.

So this patch is still kind of big, but very straightforward. It just deletes a bunch of typedefs, proc member declarations and assignments that were the old resolver. Then it changes each call to the old symbol resolver to use the new one (e.g. m_internal->bindFramebuffer becomes glBindFramebuffer etc.) - so just a bunch of single line diffs where it's very clear what is changing.

I think this will be much easier to review.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.