[Webkit-unassigned] [Bug 64745] JSC GC lazy sweep does not inline the common cases of cell destruction

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64745





--- Comment #3 from Filip Pizlo <fpizlo at apple.com>  2011-07-18 13:59:07 PST ---
(In reply to comment #2)
> (From update of attachment 101197 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=101197&action=review
> 
> r- :(
> 
> > Source/JavaScriptCore/heap/MarkedBlock.cpp:96
> > +            if (*reinterpret_cast<void**>(cell) == jsFinalObjectVPtr) {
> 
> use cell->vptr();

Ah, that's handy!

> > Source/JavaScriptCore/heap/MarkedBlock.cpp:99
> > +                if (!object->isUsingInlineStorage())
> > +                    delete [] object->m_propertyStorage;
> 
> object->JSFinalObject::~JSFinalObject() didn't work?

I tried object->~JSFinalObject() but that didn't give a speed-up.  I forgot the object->JSFinalObject::~JSFinalObject syntax.  That works great.  Doing some quick tests and will resubmit shortly...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.