[Webkit-unassigned] [Bug 64745] JSC GC lazy sweep does not inline the common cases of cell destruction

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64745


Oliver Hunt <oliver at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #101197|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #2 from Oliver Hunt <oliver at apple.com>  2011-07-18 13:53:48 PST ---
(From update of attachment 101197)
View in context: https://bugs.webkit.org/attachment.cgi?id=101197&action=review

r- :(

> Source/JavaScriptCore/heap/MarkedBlock.cpp:96
> +            if (*reinterpret_cast<void**>(cell) == jsFinalObjectVPtr) {

use cell->vptr();

> Source/JavaScriptCore/heap/MarkedBlock.cpp:99
> +                if (!object->isUsingInlineStorage())
> +                    delete [] object->m_propertyStorage;

object->JSFinalObject::~JSFinalObject() didn't work?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.