[Webkit-unassigned] [Bug 64315] Web Inspector: audit extensions need a way to link directly to resources

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64315





--- Comment #4 from Boris Smus <smus at google.com>  2011-07-18 10:41:55 PST ---
(In reply to comment #3)
> (From update of attachment 101119 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=101119&action=review
> 
> > WebCore/inspector/front-end/AuditFormatters.js:95
> > +        var title = url.replace(/\\/g,"/").replace( /.*\//, "" ) + ":" + line;
> 
> - spaces within parenthesis in a second replace() are redundant;
> - // in the second RegExp is likely to confuse MinJS that we use on chromium to minify the inspector code;
> - do we really need first replace? I'd put it as something like title = url.replace(/.*[/\\]/, "")

Good idea. Simplified to one regex: /.*[\/\\]/ (escaping the "/")

> 
> > WebCore/inspector/front-end/AuditFormatters.js:99
> > +        a.title = title;
> 
> We use the entire URL as a tooltip in other places, is using abbreviated URL here intentional?

Not intentional. Changed.

> 
> > WebCore/inspector/front-end/AuditFormatters.js:100
> > +        a.style = "max-width: 100%";
> 
> Does this line actually have effect?

IIRC in my testing before, it to affect cases where the filename was very long (composed of a GUID). But I haven't been able to repro this, so removed from the patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.