[Webkit-unassigned] [Bug 64315] Web Inspector: audit extensions need a way to link directly to resources

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64315





--- Comment #3 from Andrey Kosyakov <caseq at chromium.org>  2011-07-18 02:22:50 PST ---
(From update of attachment 101119)
View in context: https://bugs.webkit.org/attachment.cgi?id=101119&action=review

> WebCore/inspector/front-end/AuditFormatters.js:95
> +        var title = url.replace(/\\/g,"/").replace( /.*\//, "" ) + ":" + line;

- spaces within parenthesis in a second replace() are redundant;
- // in the second RegExp is likely to confuse MinJS that we use on chromium to minify the inspector code;
- do we really need first replace? I'd put it as something like title = url.replace(/.*[/\\]/, "")

> WebCore/inspector/front-end/AuditFormatters.js:99
> +        a.title = title;

We use the entire URL as a tooltip in other places, is using abbreviated URL here intentional?

> WebCore/inspector/front-end/AuditFormatters.js:100
> +        a.style = "max-width: 100%";

Does this line actually have effect?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.