[Webkit-unassigned] [Bug 64683] [EFL] Method ewk_context_menu_destroy returns EINA_FALSE if CONTEXT_MENUS is disabled

Mon Jul 18 08:35:51 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=64683

--- Comment #4 from Raphael Kubo da Costa <kubo at profusion.mobi>  2011-07-18 08:35:51 PST ---
(In reply to comment #3)
> > I see that you are submitting a few separate patches related to context menus. Do you plan on adding these #if checks to the other functions in ewk_contextmenu.cpp?
> 
> I've sent two patches related to the context menu. First fixes build break, second one changes returned value. 
> There aren't more references to WebCore's context menu object (controller) by API that are not surrounded by CONTEXT_MENUS macro. I don't think so others methods should check this macro. What is your opinion on that?

Let's not fix what's not broken ;) If the rest works, I think it's OK to leave it as it is.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.