[Webkit-unassigned] [Bug 64683] [EFL] Method ewk_context_menu_destroy returns EINA_FALSE if CONTEXT_MENUS is disabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64683





--- Comment #3 from Grzegorz <g.czajkowski at samsung.com>  2011-07-18 07:46:38 PST ---
(In reply to comment #2)
> The ChangeLog entry sounds a bit confusing to me -- the one-line description looks like the method _currently_ does what is being described, not that this is what is being changed.
> 

Ok, I will fix ChangeLog.

> I see that you are submitting a few separate patches related to context menus. Do you plan on adding these #if checks to the other functions in ewk_contextmenu.cpp?

I've sent two patches related to the context menu. First fixes build break, second one changes returned value. 
There aren't more references to WebCore's context menu object (controller) by API that are not surrounded by CONTEXT_MENUS macro. I don't think so others methods should check this macro. What is your opinion on that?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.