[Webkit-unassigned] [Bug 64572] Initial implementation of calling WebScriptObject::callWebScriptMethod() via COM

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64572





--- Comment #8 from Anthony Johnson <anthony.johnson at flexsim.com>  2011-07-14 22:05:43 PST ---
(From update of attachment 100928)
View in context: https://bugs.webkit.org/attachment.cgi?id=100928&action=review

> Source/WebKit/win/DOMCoreClasses.cpp:112
> +    if (!wrapper)

I've noticed that in some cases, m_node's wrapper is NULL. I don't remember the specific case, but it was somewhat random, i.e. a pretty innocuous change in the HTML made the node's wrapper NULL, and another change would make it valid again. I couldn't figure out how to create a wrapper if it is not already there, so here I simply fail if it is NULL. Any suggestions?

> Source/WebKit/win/DOMCoreClasses.cpp:1006
> +    if (!wrapper)

Ditto above on the wrapper

>> Source/WebKit/win/WebScriptObject.cpp:36
>> +#include "../../WebCore/html/canvas/ArrayBufferView.h"
> 
> Alphabetical sorting problem.  [build/include_order] [4]

I don't know if this is best practices to include "../../Webcore...", but it was the only way I could figure out how to get the definition of the various ArrayBufferView types, as these headers are not copied to the distribution directory, which is the <WebCore...> directory. And should I intermingle these includes with the above in alphabetical order as the code guidelines say, or should they be out on their own?

> Source/WebKit/win/WebScriptObject.cpp:119
> +    if (arg.vt & VT_ARRAY) { // it's an array

This is the main array part. For now I've only filled out short's, int's, float's, and double's, design feedback pending, but hopefully you get the idea.

> Source/WebKit/win/WebScriptObject.cpp:165
> +        default: 

Here's the straight-forward translation piece. Pretty simple, although there are still a few things I still need to fill out going forward.

> Source/WebKit/win/WebScriptObject.cpp:200
> +{

This is mostly adapted from WebCore/bindings/objc/WebScriptObject.mm

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.