[Webkit-unassigned] [Bug 64572] Initial implementation of calling WebScriptObject::callWebScriptMethod() via COM

Thu Jul 14 22:03:57 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=64572

Anthony Johnson <anthony.johnson at flexsim.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100886|                            |review?
               Flag|                            |

--- Comment #7 from Anthony Johnson <anthony.johnson at flexsim.com>  2011-07-14 22:03:57 PST ---
(From update of attachment 100886)
View in context: https://bugs.webkit.org/attachment.cgi?id=100886&action=review

> Source/WebKit/win/WebScriptObject.cpp:158
> +        if (arrayBufferView.get()) {

You may want to look at the next few lines regarding life-cycle management, i.e. make sure I'm not creating memory leaks here.

> Source/WebKit/win/WebScriptObject.cpp:161
> +            return new (exec) WebCore::JSArrayBufferView(structure, globalObject, arrayBufferView);

This is the piece I believe where I'm not getting a proper javascript Int32Array, as I'm just creating a JSArrayBufferView. However I couldn't find a JSInt32Array, or maybe I couldn't properly include it without getting compile errors. For now I think this should be fine, though, until I figure all that out.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.