[Webkit-unassigned] [Bug 64391] [Qt] Make QtWebkit2.2 compile and run on S60 Emulator

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64391





--- Comment #6 from Hui Huang <hui_huang at yahoo.com>  2011-07-14 11:51:21 PST ---
Thanks for reviewing the patch. 

> > Source/JavaScriptCore/wtf/PageAllocatorSymbian.h:72
> > +const size_t largeReservationSize = 64*1024*1024;
> 
> Can you explain this change ?

The original value 96M causes S60 Emulator to crash on Symbian System error -4. New version of S60 Emulator doesn't seem to be able to allocate such a large chunk of memory. The problem is fixed after I reduced largeReservationSize to 64M.

> > Source/WebCore/ChangeLog:5
> > +        Fix compiling errors with QtWebkit 2.2 WINSCW build.
> 
> Can you add the [Qt] prefix for the title of the bug ? it is implied that this is Qt only if it only goes to the 2.2 branch, but would be good for consistency.

You are right. I will change it.

> 
> > Source/WebKit/qt/tests/qwebelement/tst_qwebelement.cpp:1026
> > +#if QT_VERSION >= 0x040800
> 
> This seems unrelated and perhaps should go to a different patch. Can you explain why this is needed ?

This is a separate issue. QWebElement::render only takes one parameter before Qt4.7. QWebElement::render(QPainter * painter, const QRect &) was introduced in Qt 4.8. I will create a separate bug and introduce a separate patch to be landed to the trunk.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.