[Webkit-unassigned] [Bug 64391] [Qt] Make QtWebkit2.2 compile and run on S60 Emulator

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 14 05:26:42 PDT 2011


--- Comment #5 from Laszlo Gombos <laszlo.1.gombos at nokia.com>  2011-07-14 05:26:42 PST ---
(From update of attachment 100572)
View in context: https://bugs.webkit.org/attachment.cgi?id=100572&action=review

Overall the patch looks good to me with some minor changes. As mentioned earlier this should only land in the 2.2 branch.

> Source/JavaScriptCore/wtf/PageAllocatorSymbian.h:72
> +const size_t largeReservationSize = 64*1024*1024;

Can you explain this change ?

> Source/WebCore/ChangeLog:5
> +        Fix compiling errors with QtWebkit 2.2 WINSCW build.

Can you add the [Qt] prefix for the title of the bug ? it is implied that this is Qt only if it only goes to the 2.2 branch, but would be good for consistency.

> Source/WebKit/qt/tests/qwebelement/tst_qwebelement.cpp:1026
> +#if QT_VERSION >= 0x040800

This seems unrelated and perhaps should go to a different patch. Can you explain why this is needed ?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list