[Webkit-unassigned] [Bug 45395] [GTK] DOM bindings do not have gir annotations

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 12 05:48:58 PDT 2011


--- Comment #14 from Xan Lopez <xan.lopez at gmail.com>  2011-07-12 05:48:58 PST ---
(In reply to comment #13)
> >>  }
> >>  
> >>  /**
> >> - * webkit_network_response_get_soup_message:
> >> + * webkit_network_response_get_message:
> >You are most definitely not allowed to change the function name. Not sure why >are you doing that but you can't.
> I was referring to that specifically as proof that you didn't do a proper review in my opinion (and I mentioned that in the lost comment). The fix quoted is a fix for the annotation that didn't match the corresponding function name (and not the other way around, I was not changing any API). 

I guess since in other parts of the patch you were modifying the script to generate incorrect documentation I assumed this was the case too. It wasn't, so my mistake. Anyway this one mistake does not change the fact that most of the patch was not ready suitable to be landed, so I don't really agree that my first review was not proper. I made a mistake? Ok, but I also pointed out lots of incorrect things in your patch. The normal thing to do would be to tell me about the mistake and change the rest of the stuff, not to drop the ball completely IMHO.

Also this shows why it's a good idea to send one patch per separate issue instead of doing a giant patch with all your changes. Makes things harder to review.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list