[Webkit-unassigned] [Bug 45395] [GTK] DOM bindings do not have gir annotations

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 12 05:28:47 PDT 2011


--- Comment #13 from Gabriel Jacobo <gabomdq at gmail.com>  2011-07-12 05:28:47 PST ---
>>  }
>>  /**
>> - * webkit_network_response_get_soup_message:
>> + * webkit_network_response_get_message:

>You are most definitely not allowed to change the function name. Not sure why >are you doing that but you can't.

I was referring to that specifically as proof that you didn't do a proper review in my opinion (and I mentioned that in the lost comment). The fix quoted is a fix for the annotation that didn't match the corresponding function name (and not the other way around, I was not changing any API). 
So if you say that my comment wasn't deleted I believe you and I apologize for saying so, it certainly seemed strange to delete a comment over some minor bashing...but with the power trips some people go on over the internet, you never know.
Anyway, good luck Arno with the patch, feel free to contact me if you have questions (I've noted down part of the thinking behind this in some older posts in my blog at mdqinc.com)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list