[Webkit-unassigned] [Bug 45395] [GTK] DOM bindings do not have gir annotations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45395


arno. <arno at renevier.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100360|0                           |1
        is obsolete|                            |
 Attachment #100448|                            |review?
               Flag|                            |




--- Comment #9 from arno. <arno at renevier.net>  2011-07-12 01:21:23 PST ---
Created an attachment (id=100448)
 --> (https://bugs.webkit.org/attachment.cgi?id=100448&action=review)
patch for issue 3

(In reply to comment #8)
> (From update of attachment 100360 [details])

> > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:791
> > +    $selfClass =~ s/\*$//;
> 
> I think $className does not end in *, so this seems redundant.

fixed

> > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:795
> > +        my $paramIDLType = $param->type;
> 
> Minor nit, probably you can do without this variable.

fixed

> > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:797
> > +        $paramType =~ s/\*$//;        
> 
> Same than first comment.

fixed

> > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:806
> > +        push(@hBody, " * Returns: (transfer none):\n");    
> 
> Answering to your question, this is OK. GDOM objects are GC by WebKit automatically, so there's no need to manually unref them. transfer: full would also be OK, since it's possibly to unref them manually too. So AFAIK this is mostly up to us. transfer none is probably safer, so I think we can start with that.

ok, thanks for your answer.
Here is a new patch with a changelog. I fell like I'm "hijacking" Gabriel's patch but hopefully, that will help getting annotations for dom methods.
Also, I 
push(@hBody, " * Returns:\n");
if return type is not dom class type.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.