[Webkit-unassigned] [Bug 45395] [GTK] DOM bindings do not have gir annotations

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 11 15:08:59 PDT 2011


Xan Lopez <xan.lopez at gmail.com> changed:

           What    |Removed                     |Added
 Attachment #100360|                            |review-
               Flag|                            |

--- Comment #8 from Xan Lopez <xan.lopez at gmail.com>  2011-07-11 15:08:59 PST ---
(From update of attachment 100360)
View in context: https://bugs.webkit.org/attachment.cgi?id=100360&action=review

This looks OK, but it needs a ChangeLog to get r+. Please read http://www.webkit.org/coding/contributing.html, especially the bit about generating a proper ChangeLog. Thanks for the patch!

> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:791
> +    $selfClass =~ s/\*$//;

I think $className does not end in *, so this seems redundant.

> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:795
> +        my $paramIDLType = $param->type;

Minor nit, probably you can do without this variable.

> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:797
> +        $paramType =~ s/\*$//;        

Same than first comment.

> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:806
> +        push(@hBody, " * Returns: (transfer none):\n");    

Answering to your question, this is OK. GDOM objects are GC by WebKit automatically, so there's no need to manually unref them. transfer: full would also be OK, since it's possibly to unref them manually too. So AFAIK this is mostly up to us. transfer none is probably safer, so I think we can start with that.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list