[Webkit-unassigned] [Bug 62840] Optimize HTMLInputElement::updateCheckedRadioButtons

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62840


zeng huiqing <huiqing.zeng at intel.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100267|0                           |1
        is obsolete|                            |
 Attachment #100433|                            |review?, commit-queue?
               Flag|                            |




--- Comment #9 from zeng huiqing <huiqing.zeng at intel.com>  2011-07-11 20:53:12 PST ---
Created an attachment (id=100433)
 --> (https://bugs.webkit.org/attachment.cgi?id=100433&action=review)
new patch

Many thanks for helping review the patch and the good comments:)

1)I have changed 'if(type()!=(InputTypeNames::checkbox()))' to 'if(type()==(InputTypeNames::radio()))', but I'm sorry that I'm not sure that besides 'radio', we don't need to call updateCheckedRadioButtons() for all the other types of input element?

2)The next attachement is the micro-benchmark I use to test the page loading performance, run "./chrome --allow-file-access-from-files omedia_workload4_iterations_rev5x5.html" to get the result, and the result shows that Chromium(build 91994) w/ patch ~1.3x faster to load page radio.html(heavily using 'radio').
My test Platform: 4G i7 860 Ubuntu 10.04

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.