[Webkit-unassigned] [Bug 61346] --webkit-visual-word: ctrl-arrow is not able to reach the boundary of line

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61346


Xiaomei Ji <xji at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vanlam at google.com




--- Comment #8 from Xiaomei Ji <xji at chromium.org>  2011-07-11 16:48:10 PST ---
(In reply to comment #6)
> (From update of attachment 100372 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=100372&action=review
> 
> I'm concerned that this code is really losing the original benefit of not doing linear search.  I feel like we can get a cleaner & more efficient code by collecting all word break in a visual position.

The word breaks are still visually ordered.
For example, "abc def" in LTR context,
previously, only word break "abc |def" and "|abc def" are collected, and they are collected visually right to left. 
Now, word break "abc def|" is collected at first, so the word breaks are still visually ordered as before.

The only difference is that:
for LTR block, the rightmost line boundary is collect as a word break in rightmost box. 
for RTL block, the leftmost line boundary is collect as a word break in leftmost box.

Since logicalEndOfLine might be costly, we are still working on finding a general solution to avoid using logicalEndOfLine to get the rightmost/leftmost line boundary position. Maybe by checking box's bidi-level (and only cover bidi-level 0, 1, 2, 3 for now).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.