[Webkit-unassigned] [Bug 61346] --webkit-visual-word: ctrl-arrow is not able to reach the boundary of line

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 11 16:30:30 PDT 2011


--- Comment #7 from Xiaomei Ji <xji at chromium.org>  2011-07-11 16:30:30 PST ---
(From update of attachment 100372)
View in context: https://bugs.webkit.org/attachment.cgi?id=100372&action=review

> Source/WebCore/ChangeLog:5
> +	Added the word boundary corresponding to the logical end-of-line to the


> Source/WebCore/editing/visible_units.cpp:1442
> +static void collectWordBreaksInBoxInsideBlockWithSameDirectionality(const InlineBox* box, WordBoundaryVector& orderedWordBoundaries, TextDirection blockDirection)

you do not need to pass blockDirection. You can use the box direction since the box direction == block direction in this function.

> Source/WebCore/editing/visible_units.cpp:1469
> +static void collectWordBreaksInBoxInsideBlockWithDifferntDirectionality(const InlineBox* box, WordBoundaryVector& orderedWordBoundaries, TextDirection blockDirection)

no need to pass blockDirection

> Source/WebCore/editing/visible_units.cpp:1637
> +        return VisiblePosition();

this and the corresponding test are covered in https://bugs.webkit.org/attachment.cgi?id=98417&action=review, so I think you can remove it from this patch.

> Source/WebCore/editing/visible_units.cpp:1680
> +        return VisiblePosition();


> LayoutTests/ChangeLog:5
> +	Modified two tests to test for visual word movement to end-of-line.


> LayoutTests/editing/selection/move-by-word-visually-single-space-sigle-line-expected.txt:98
>  Test 20, RTL:

the html file seems changed, but why the test expectation is not change?
same for test 21.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list