[Webkit-unassigned] [Bug 64260] [EFL] ewk_frame_hit_test_new enhancement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64260





--- Comment #5 from Michal Pakula vel Rutka <m.pakula at samsung.com>  2011-07-11 06:56:57 PST ---
(In reply to comment #4)
> When you update the patch, please describe briefly what has changed in the new version, otherwise one needs to use "Diff" -> "Differences between" to find out.
> 

OK

> > Source/WebKit/efl/ewk/ewk_frame.cpp:1068
> > +    hit_test->context = (Ewk_Hit_Test_Result_Context)context;
> 
> Do you really need this cast? If so, please use a C++ cast.
> 

Yes, I think is needed here, anyway I will change it to static_cast.

> > Tools/EWebLauncher/main.c:558
> > +                   "%s"
> 
> Perhaps indent the lines here instead of below? This way you'd have
> 
>   "  %s\n"
>   /* code */
>   ht->context & EWK_HIT_TEST_RESULT_FOO ? "FOO" : "",
> 

But then when ht->context & EWK_HIT_TEST_RESULT_FOO will be false we will get two spaces and there will be problem with aligning contexts.

> > Tools/EWebLauncher/main.c:573
> > +                   ht->context & EWK_HIT_TEST_RESULT_CONTEXT_LINK ? "  LINK\n": "",
> 
> Pleas add a space before the ":"

OK

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.