[Webkit-unassigned] [Bug 64260] [EFL] ewk_frame_hit_test_new enhancement

Mon Jul 11 06:32:14 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=64260

Raphael Kubo da Costa <kubo at profusion.mobi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kubo at profusion.mobi

--- Comment #4 from Raphael Kubo da Costa <kubo at profusion.mobi>  2011-07-11 06:32:14 PST ---
When you update the patch, please describe briefly what has changed in the new version, otherwise one needs to use "Diff" -> "Differences between" to find out.

> Source/WebKit/efl/ewk/ewk_frame.cpp:1068
> +    hit_test->context = (Ewk_Hit_Test_Result_Context)context;

Do you really need this cast? If so, please use a C++ cast.

> Tools/EWebLauncher/main.c:558
> +                   "%s"

Perhaps indent the lines here instead of below? This way you'd have

  "  %s\n"
  /* code */
  ht->context & EWK_HIT_TEST_RESULT_FOO ? "FOO" : "",

> Tools/EWebLauncher/main.c:573
> +                   ht->context & EWK_HIT_TEST_RESULT_CONTEXT_LINK ? "  LINK\n": "",

Pleas add a space before the ":"

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.