[Webkit-unassigned] [Bug 64262] Small speed up, which switches some virtual functions to inline ones.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 11 06:05:42 PDT 2011


Zoltan Herczeg <zherczeg at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #100268|review?                     |review-
               Flag|                            |

--- Comment #5 from Zoltan Herczeg <zherczeg at webkit.org>  2011-07-11 06:05:42 PST ---
(From update of attachment 100268)
View in context: https://bugs.webkit.org/attachment.cgi?id=100268&action=review

> Source/WebCore/css/CSSImageGeneratorValue.h:53
>      virtual IntSize fixedSize(const RenderObject*) { return IntSize(); }

Such function must remain virtal, as it can be called from its base class (if exists), or from its descendants. I would not overwrite them except if we got a permission from the author of those functions, and done them one-by-one.

There are several others like this.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list