[Webkit-unassigned] [Bug 64262] Small speed up, which switches some virtual functions to inline ones.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64262


Gabor Loki <loki at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100268|commit-queue-               |commit-queue?
               Flag|                            |




--- Comment #4 from Gabor Loki <loki at webkit.org>  2011-07-11 05:49:26 PST ---
(From update of attachment 100268)
View in context: https://bugs.webkit.org/attachment.cgi?id=100268&action=review

> Source/WebCore/css/CSSImageGeneratorValue.h:70
> +    bool m_isFixedSize;

You should initialize it.

> Source/WebCore/css/CSSPrimitiveValue.cpp:115
>  CSSPrimitiveValue::CSSPrimitiveValue()

Could we move all CSSPrimitiveValue::CSSPrimitiveValue constructors into the header file?

> Source/WebCore/css/CSSPrimitiveValue.h:189
> +    bool m_isQuirkValue;

It should be protected.

> Source/WebCore/css/CSSValue.h:77
> +    bool m_isPrimitiveValue;

It should be protected as well.

> Source/WebCore/css/CSSValue.h:81
> +    CSSValue()
> +        :m_isPrimitiveValue(false)
> +    {
> +    }

It is not in WebKit style (the check-webkit-style should complain about it).
Please, move up the constructor after 'public:' and add space between ':' and m_isPrimitiveValue

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.