[Webkit-unassigned] [Bug 26755] webkit-patch's commit messages are less readable than commit-log-editor's

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 7 10:45:16 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=26755





--- Comment #32 from Adam Barth <abarth at webkit.org>  2011-07-07 10:45:15 PST ---
@ddkilzer: This patch contains a couple architectural mistakes.  For example, grabbing the executive statically rather than using the dependency injection layer is a subtle but important violation of an invariant that we try to maintain across the entire codebase.

In the future, it might be better to give someone who works on webkitpy frequently a chance to look at a patch before landing it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list