[Webkit-unassigned] [Bug 26755] webkit-patch's commit messages are less readable than commit-log-editor's

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 7 10:41:16 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=26755





--- Comment #31 from Adam Barth <abarth at webkit.org>  2011-07-07 10:41:16 PST ---
(From update of attachment 99987)
View in context: https://bugs.webkit.org/attachment.cgi?id=99987&action=review

> Tools/Scripts/webkitpy/common/checkout/checkout.py:123
> +        message_text = Executive().run_command([self._scm.script_path('commit-log-editor'), '--print-log'] + changelog_paths, return_stderr=False)

This isn't correct.  You need to get the executive from the tool so that it is mocked out correctly in unit tests.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list