[Webkit-unassigned] [Bug 64086] [Qt] NRWT should pick up the right httpd config file
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 7 10:11:40 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=64086
--- Comment #3 from Eric Seidel <eric at webkit.org> 2011-07-07 10:11:39 PST ---
(From update of attachment 99977)
View in context: https://bugs.webkit.org/attachment.cgi?id=99977&action=review
> Tools/Scripts/webkitpy/layout_tests/port/qt.py:32
> +import os
Don't need this once you use FileSystem.
> Tools/Scripts/webkitpy/layout_tests/port/qt.py:69
> + if os.path.isfile('/etc/debian_version'):
Oh, this is wrong too. This should use self._filesystem.exists() or isfile if that method exists on FileSystem. We don't ever talk to os directly if we can help it. (Makes mockng hard.)
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list