[Webkit-unassigned] [Bug 64086] [Qt] NRWT should pick up the right httpd config file

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 7 10:10:37 PDT 2011


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
  Attachment #99977|review?, commit-queue?      |review-
               Flag|                            |

--- Comment #2 from Eric Seidel <eric at webkit.org>  2011-07-07 10:10:37 PST ---
(From update of attachment 99977)
OK.  There is a similar "is_redhat_based()" function in the Gtk port.

Please add a test for this in qt_unittest.py.  Should be very easy to do with MockFileSystem({'/etc/debian_version', ''})

Something like this:

def test_is_debian_based(self)
    port = self.make_port() # This is available in PortTestCase which QtPortTest isn't yet, I don't think, but could be made to
    self.assertEqual(port.is_debian_based(), False)
    port._filesystem = MockFileSystem({'/etc/debian_version', ''})
    self.assertEqual(port.is_debian_based(), True)

One could also test that overriding _is_debian_based() with lamba: False or lambda: True affected port._path_to_appache_config_file().basename() if you wanted.  In any case, we just need some sort of testing.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list