[Webkit-unassigned] [Bug 53389] [Gtk] atk_text_set_caret_offset returns True even when it is unsuccessful

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53389


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #80646|review?                     |review+
               Flag|                            |




--- Comment #4 from Martin Robinson <mrobinson at webkit.org>  2011-01-31 09:36:57 PST ---
(From update of attachment 80646)
View in context: https://bugs.webkit.org/attachment.cgi?id=80646&action=review

> Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:1714
> +    RenderObject* renderer = toAccessibilityRenderObject(coreObject)->renderer();
> +    if (renderer && renderer->isListItem()) {
> +        String markerText = toRenderListItem(renderer)->markerTextWithSuffix();
> +        int markerLength = g_utf8_strlen(markerText.utf8().data(), -1);
> +        if (offset < markerLength)
> +            return FALSE;
> +
> +        // We need to adjust the offset for list items.
> +        offset -= markerLength;
> +    }

Please mention this change in the ChangeLog as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.