[Webkit-unassigned] [Bug 53389] [Gtk] atk_text_set_caret_offset returns True even when it is unsuccessful

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53389


Mario Sanchez Prada <msanchez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #80646|                            |review?
               Flag|                            |




--- Comment #3 from Mario Sanchez Prada <msanchez at igalia.com>  2011-01-31 09:17:24 PST ---
Created an attachment (id=80646)
 --> (https://bugs.webkit.org/attachment.cgi?id=80646&action=review)
Patch proposal + unit tests

Attaching a patch to fix this issue.

Notice that I included the needed code to consider list item markers (so we return FALSE in case you try to set the caret in the middle of them), as it's part of the solution for this bug, even if bug 53388 is not fixed yet and hence set_caret_offset will return FALSE always regardless of the offset being in the item's marker or in the item's text :-)

Asking for review now...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.