[Webkit-unassigned] [Bug 47264] Introduce the device element as an experimental feature

Thu Jan 27 21:59:32 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=47264

Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #80411|review?                     |review-
               Flag|                            |

--- Comment #6 from Adam Barth <abarth at webkit.org>  2011-01-27 21:59:32 PST ---
(From update of attachment 80411)
View in context: https://bugs.webkit.org/attachment.cgi?id=80411&action=review

r- for build failures and changing the parser without adding a test.

> Source/WebCore/html/parser/HTMLTreeBuilder.cpp:897
> +#if ENABLE(DEVICE_ELEMENT)
> +        || token.name() == deviceTag
> +#endif

HTML parsing should not be conditional on which features are enabled.  If this line of could should be here, it should be here unconditionally and we should have parser test that demonstrates this change.

> Source/WebCore/platform/device/StreamDeviceManager.cpp:38
> +#if 0

#if 0 ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.